From 4992185323ece8b3c7122537cb5a9019caed5adb Mon Sep 17 00:00:00 2001 From: dec05eba Date: Fri, 7 Nov 2025 22:11:43 +0100 Subject: [PATCH] Make it clear that led indicator is only supported by x11 --- TODO | 4 +++- src/gui/ScreenshotSettingsPage.cpp | 2 +- src/gui/SettingsPage.cpp | 6 +++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index c00d893..03942fb 100644 --- a/TODO +++ b/TODO @@ -243,4 +243,6 @@ Add option to trim video in the ui. Show a list of all videos recorded so you do Show the currently recorded capture in the ui, to preview if everything looks ok. This is also good for webcam overlay. Do this when gsr supports rpc, which would also include an option to get a fd to the capture texture. -Show a question mark beside options. When hovering the question mark show a tooltip that explains the options. \ No newline at end of file +Show a question mark beside options. When hovering the question mark show a tooltip that explains the options. + +Make led indicator work on wayland (set led with /sys/... blabla with root access). \ No newline at end of file diff --git a/src/gui/ScreenshotSettingsPage.cpp b/src/gui/ScreenshotSettingsPage.cpp index 10e99ba..1a64457 100644 --- a/src/gui/ScreenshotSettingsPage.cpp +++ b/src/gui/ScreenshotSettingsPage.cpp @@ -229,7 +229,7 @@ namespace gsr { } std::unique_ptr ScreenshotSettingsPage::create_led_indicator() { - auto checkbox = std::make_unique(&get_theme().body_font, "Blink scroll lock led when taking a screenshot"); + auto checkbox = std::make_unique(&get_theme().body_font, gsr_info->system_info.display_server == DisplayServer::X11 ? "Blink scroll lock led when taking a screenshot" : "Blink scroll lock led when taking a screenshot (not supported by Wayland)"); checkbox->set_checked(true); led_indicator_checkbox_ptr = checkbox.get(); return checkbox; diff --git a/src/gui/SettingsPage.cpp b/src/gui/SettingsPage.cpp index 3a5188f..d8f4e08 100644 --- a/src/gui/SettingsPage.cpp +++ b/src/gui/SettingsPage.cpp @@ -832,7 +832,11 @@ namespace gsr { std::unique_ptr SettingsPage::create_led_indicator(const char *type) { char label_str[256]; - snprintf(label_str, sizeof(label_str), "Show %s status with scroll lock led", type); + if(gsr_info->system_info.display_server == DisplayServer::X11) + snprintf(label_str, sizeof(label_str), "Show %s status with scroll lock led", type); + else + snprintf(label_str, sizeof(label_str), "Show %s status with scroll lock led (not supported by Wayland)", type); + auto checkbox = std::make_unique(&get_theme().body_font, label_str); checkbox->set_checked(false); led_indicator_checkbox_ptr = checkbox.get();